offline pin:minor fix and icon change to fit properly#2528
Open
rockhero1234 wants to merge 2 commits intorecloudstream:masterfrom
Open
offline pin:minor fix and icon change to fit properly#2528rockhero1234 wants to merge 2 commits intorecloudstream:masterfrom
rockhero1234 wants to merge 2 commits intorecloudstream:masterfrom
Conversation
Contributor
rockhero1234
commented
Feb 21, 2026
rockhero1234
commented
fire-light42
requested changes
Feb 24, 2026
| parentId = it.parentId, | ||
| name = it.name ?: act.getString(R.string.downloaded_file), | ||
| name = it.name | ||
| ?: (act.getString(R.string.episode) + it.episode), |
Collaborator
There was a problem hiding this comment.
This contains three fundamental issues.
- This may get triggered on a movie without a name.
- There is no spacing between episode and the number resulting in "Episode1"
- Episode number and season are already shown in the player? It would result in something like:
Episode 1 - 1920x1080
Breaking Bad "S1:E1" - Episode 1 ✓
Contributor
Author
There was a problem hiding this comment.
I changed subName if name is downloaded file it may work
| android:layout_marginStart="2dp" | ||
| android:layout_width="15dp" | ||
| android:layout_height="15dp" | ||
| android:layout_marginStart="1dp" |
Collaborator
There was a problem hiding this comment.
Should the TV player not get changed too?
Contributor
Author
There was a problem hiding this comment.
That's already aligned
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.